[MINOR] off-by-one error in CSV header writing - #2557
Open
t99-i wants to merge 2 commits into
Open
Conversation
Author
Contributor
|
Thanks for identifying and fixing the issue @t99-i. It would be great if you could include a test case which would fail with the old implementation. |
- added corresponding test which should fail with the old implementation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2557 +/- ##
============================================
+ Coverage 71.36% 71.59% +0.23%
- Complexity 48688 50281 +1593
============================================
Files 1570 1623 +53
Lines 188757 194314 +5557
Branches 37039 37965 +926
============================================
+ Hits 134711 139128 +4417
- Misses 43594 44288 +694
- Partials 10452 10898 +446 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed incorrect column name indexing (off-by-one error) in CSV header writing